HierarchicalMatrices.jl icon indicating copy to clipboard operation
HierarchicalMatrices.jl copied to clipboard

HierarchicalMatrices should use BlockArrays

Open dlfivefifty opened this issue 7 years ago • 2 comments

BlockArrays has a well-developed block matrix structure, so this would avoid needing your own Block.

dlfivefifty avatar Nov 05 '17 09:11 dlfivefifty

You're talking mainly about the abstract block array interface, and not the concrete block array type, right? AFAICT, hierarchical matrices are block arrays where the blocks are different types, but this is staged for performance. On the other hand, the concrete block array type has templated the block type. I don't see how a getindex on the blocks would ever be performant for hierarchical matrices due to the type instability. setindex!, though is type stable.

MikaelSlevinsky avatar Nov 05 '17 18:11 MikaelSlevinsky

I meant HierarchicalMatrix{T} <: AbstractBlockMatrix{T}.

dlfivefifty avatar Nov 05 '17 19:11 dlfivefifty