Pkg.jl icon indicating copy to clipboard operation
Pkg.jl copied to clipboard

`Pkg.Registry.uncompress`: if overlapping ranges are found, print detailed debugging information in the error message

Open DilumAluthge opened this issue 3 years ago • 7 comments

Fixes #2899

@andreasnoack and I ran into this error with a private registry, and it was very difficult to pinpoint the exact location of the problem, because the current error message does not provide very much information.

With this PR, the error message for overlapping ranges will include the following data:

  1. Registry.toml -> path
  2. Registry.toml -> registry_path
  3. Registry.toml -> name
  4. Registry.toml -> uuid
  5. Package.toml -> repo
  6. Package.toml -> subdir

This should make it much easier to figure out where the problem is.

DilumAluthge avatar Feb 14 '22 02:02 DilumAluthge

This seems like a great improvement to me (and it fixes a clear bug). I'm not familiar with this code so I'll let others review.

andreasnoack avatar Feb 14 '22 08:02 andreasnoack

I think we just hit this too (not my machine and via zoom, so I can't do a detailed diagnosis).

timholy avatar Mar 30 '22 18:03 timholy

Needs a review from someone that knows the code.

DilumAluthge avatar Mar 30 '22 18:03 DilumAluthge

Bump @KristofferC

DilumAluthge avatar Mar 30 '22 18:03 DilumAluthge

@KristofferC bumping this again

andreasnoack avatar Sep 23 '22 13:09 andreasnoack

Bump @KristofferC

DilumAluthge avatar Oct 08 '22 09:10 DilumAluthge

There are some conflicts here now. Are the changes still relevant?

andreasnoack avatar Jan 28 '24 21:01 andreasnoack