GPUArrays.jl icon indicating copy to clipboard operation
GPUArrays.jl copied to clipboard

Published 20 hours ago • verified publisher icon JuliaGPU

Re-add convolution kernel

Open davidbp opened this issue 7 years ago • 3 comments

I have looked at the convolution! code but there are some details I am missing.

  • Can the kernel have any shape?
  • It seems the method returns the same shape of the original but there is no option for padding or not padding.

Wouldn't it be nice to have some documentation and several tests showing how to use it?

I have done some tests: https://github.com/davidbp/learn_julia/blob/master/GPU_compute/GPUArrays/GPUArrays_convolution.ipynb

davidbp avatar May 28 '18 21:05 davidbp

That was just a very simple first stab at it... @americast, this could be one of your next tasks :)

SimonDanisch avatar Jun 01 '18 09:06 SimonDanisch

In the documentation it might be ilustrative to add some gifs:

  • https://github.com/vdumoulin/conv_arithmetic

davidbp avatar Jun 01 '18 10:06 davidbp

Update: this kernel has been removed, so would need to be re-added if somebody is interested. Old code here: https://github.com/JuliaGPU/GPUArrays.jl/commit/0868d9f47af8bbe8cdd861a60a879f0bbe9c8917 Would probably need to integrate with DSP.jl, but there doesn't seem to be an AbstractDSP.jl (cfr. FFT.jl).

maleadt avatar Jan 28 '20 13:01 maleadt