GPUArrays.jl icon indicating copy to clipboard operation
GPUArrays.jl copied to clipboard

max pool

Open americast opened this issue 7 years ago • 3 comments

An implementation of maxpool. Here's a sample benchmarking (CPU v/s GPU): https://gist.github.com/americast/95358d972647adf5c7ebcde7c58db51f

Tests were failing due to getindex is disabled error. I have made a small change in src/indexing.jl as a workaround.

Thanks.

americast avatar Apr 10 '18 21:04 americast

Lol, the assertslow is there for a reason, since scalar indexing into a gpuarray is very slow and should not be done! You can do allowslow(true) to disable that error. Since your benchmarks seem to indicate good speed, I'm guessing the problem happens on the other side of the test code. I'll check.

SimonDanisch avatar Apr 12 '18 16:04 SimonDanisch

Ouch! The benchmarks don't include padding. I should have mentioned that. Sorry, my bad. I'll create a separate benchmark with padding.

americast avatar Apr 12 '18 16:04 americast

Updated. Thank you @SimonDanisch for PR #111 and commit 1e1104e. I've updated the benchmarks at https://gist.github.com/americast/95358d972647adf5c7ebcde7c58db51f.

americast avatar Apr 20 '18 22:04 americast