Redis.jl

Redis.jl copied to clipboard

Since PR #81 has been merged into master, it would be nice to have that fix/functionality available as a tagged release rather than having to use Redis.jl#master to get it. I think it is technically breaking since it changes the value passed to subscription handler functions, so maybe v1.1.0?

I just noticed that Project.toml on master already specifies the version as v1.1.0 so I guess it just needs to be tagged as such.

Hi David,

I'm happy to tag a new release. I think the process for this changed within the past year or so (maybe earlier) and I have not been actively keeping up with the Julia ecosystem since then. Is this something that can be resolved with a PR or should I be looking into setting up some new CD for the repo?

I think the breaking change means that it should be v2.0.0 - any package with a compat field set to 1 or 1.1 could break if the version only goes up to 1.1.0.

The easiest way to register now is to use @JuliaRegistrator and @JuliaTagBot.

It may be worth thinking if there are any other breaking changes that may want to be done, and lumping them in together?

EDIT: Sorry I made the registrator comment!

Error while trying to register: Action not recognized: and

Error while trying to register: Action not recognized: and

I'm unaware of any pending changes that would necessitate a major version bump. #76 is the only open feature request right now, which would be additive and only a minor bump.

I was thinking that #81 technically changes the public API (subscription callback function now receives different inputs to before), and therefore needs a major version bump as it's a breaking change.

Sorry, yes I agree with that. I meant there aren't any others pending.

On Tue, Sep 14, 2021, 1:50 AM Mal Miller @.***> wrote:

I was thinking that #81 https://github.com/JuliaDatabases/Redis.jl/pull/81 technically changes the public API (subscription callback function now receives different inputs to before), and therefore needs a major version bump as it's a breaking change.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/JuliaDatabases/Redis.jl/issues/82#issuecomment-918901882, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7FL7B4T3WZG6WT7H5HKLLUB35GDANCNFSM5AKNTEVQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Ah of course, sorry for misunderstanding

Bump on this; is there something we can help with?

Thanks!

If you'd like to tag/upload the release, I would be happy to accept a PR for this