PkgTemplates.jl ProjectFile has a None option

ProjectFile has a None option

Open mbauman opened this issue 5 years ago • 5 comments

This was a little funny:

ProjectFile keywords to customize:
[press: d=done, a=all, n=none]
   [X] version
 > [X] None

With both selected, the None option seemed to win. Seems like this None option should be removed.

Jun 03 '20 21:06 mbauman

It's an implementation detail of TerminalMenus, you can't create a menu with just one entry. 🙁

Jun 03 '20 21:06 christopher-dG

Ah, that's unfortunate. Perhaps this should be an upstream issue? Seems like a 1-element menu should make sense and be easy to support.

cf. https://github.com/JuliaLang/julia/pull/35915#issuecomment-638316817

Jun 04 '20 14:06 mbauman

Yeah, I agree. Tbh we're probably better off using the non-stdlib version because the stdlib will never backport these kinds of changes to 1.0.

Jun 04 '20 14:06 christopher-dG

FYI, single option menu for REPL.TerminalMenus just got merged (likely available with Julia 1.6+): JuliaLang/julia#36369

Jun 22 '20 17:06 tomyun

I think some people have said that 1.6 has potential to be the next LTS, so when that comes we can make the change 🙂

Jun 22 '20 17:06 christopher-dG