flutter_subtitle_wrapper icon indicating copy to clipboard operation
flutter_subtitle_wrapper copied to clipboard

Remove listener when bloc is closed

Open wwwdata opened this issue 3 years ago โ€ข 2 comments

Description

I found out that when the bloc was closed, it was not properly removing the listener that updates the bloc state. This is problematic when the video wrapper widget is used in more than one place. For example in a larger fullscreen view as well on a different screen.

Type of Change

  • [ ] โœจ New feature (non-breaking change which adds functionality)
  • [x] ๐Ÿ› ๏ธ Bug fix (non-breaking change which fixes an issue)
  • [ ] โŒ Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] ๐Ÿงน Code refactor
  • [ ] โœ… Build configuration change
  • [ ] ๐Ÿ“ Documentation
  • [ ] ๐Ÿ—‘๏ธ Chore

wwwdata avatar Aug 18 '22 14:08 wwwdata

Ah this indeed sounds like a issue, will have a quick check and then merge it!

Joran-Dob avatar Aug 18 '22 15:08 Joran-Dob

Codecov Report

Merging #71 (67221d4) into main (2d065de) will increase coverage by 0.38%. The diff coverage is 14.28%.

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   57.27%   57.65%   +0.38%     
==========================================
  Files          13       13              
  Lines         220      222       +2     
==========================================
+ Hits          126      128       +2     
  Misses         94       94              
Impacted Files Coverage ฮ”
lib/bloc/subtitle/subtitle_bloc.dart 60.60% <14.28%> (+2.54%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 01 '22 07:09 codecov[bot]