svg-sprite-loader icon indicating copy to clipboard operation
svg-sprite-loader copied to clipboard

Published 20 hours ago • verified publisher icon JetBrains

fix: Fix DeprecationWarning: Module.issuer: Use new ModuleGraph API

Open MalikBen opened this issue 4 years ago • 9 comments

What kind of change does this PR introduce? (bugfix, feature, docs update, improvement) Removes warning by using ModuleGraph in case of webpack version >= 5 What is the current behavior? (You can also link to an open issue here) webpack5 build throws a DeprecationWarning [DEP_WEBPACK_MODULE_ISSUER] DeprecationWarning: Module.issuer: Use new ModuleGraph API See #418 What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills contributing guidelines

MalikBen avatar Dec 10 '20 16:12 MalikBen

checks failed , @MalikBen

zhongzhong0505 avatar Jan 07 '21 06:01 zhongzhong0505

@MalikBen

Looks like test for Env "webpack-2" are failing. Does webpack 2 exports version? If not then can you try changing:

const isWebpackGreaterThan5 = version[0] >= 5;

to

const isWebpackGreaterThan5 = version && version[0] >= 5;

dmnsgn avatar Jan 09 '21 12:01 dmnsgn

ping @MalikBen

flyyang avatar Jan 21 '21 07:01 flyyang

ping @MalikBen

liuliangsir avatar Feb 03 '21 09:02 liuliangsir

@pbn04001 can I open a new PR to fix this warning?

b-e-r-t-o avatar Mar 23 '21 20:03 b-e-r-t-o

@b-e-r-t-o Yes, you can

d3x42 avatar Apr 10 '21 07:04 d3x42

Hi, I'm sorry I was receiving all the e-mails in my spam box, is this issue fixed ? Should I close it ?

MalikBen avatar Dec 08 '22 15:12 MalikBen

For what it's worth, I'm no longer seeing this issue. Probably best to wait until a few others weight in before closing it, though, IMHO 🙂

Eli-Black-Work avatar Dec 09 '22 06:12 Eli-Black-Work

Wait, nvm, I was testing with an outdated version of svg-sprite-loader. Please disregard my answer 🙂

Eli-Black-Work avatar Dec 09 '22 07:12 Eli-Black-Work