PHP-Var-Dump-Check icon indicating copy to clipboard operation
PHP-Var-Dump-Check copied to clipboard

Add --custom-function parameter to check.

Open umutphp opened this issue 6 years ago • 5 comments

In one of the projects that I have been working for a while, there are some legacy dump functions created and used frequently by the team. A sample function is;

function pre_dump( $var ) { echo '<pre>'; var_dump( $var ); echo '</pre>'; }

The check can not be able to find the usage of this kind of functions. With this pull request, user can give the names of such kind of custom debug functions to the check function with "--custom-function" parameter.

umutphp avatar Dec 11 '18 12:12 umutphp

This will fix the issue #33.

umutphp avatar Dec 19 '18 10:12 umutphp

Thanks for your pull request, I am happy to add that functionality after you resolve conflict and requested changes. Thanks! When this will be merged, I will release a new version.

JakubOnderka avatar Jan 05 '19 20:01 JakubOnderka

Is this mergable ?

kl3sk avatar Oct 23 '19 13:10 kl3sk

Is this mergable ?

@kl3sk Technically yes, but I think the owner of the repo is a bit busy for a while.

umutphp avatar Oct 24 '19 11:10 umutphp

Ok, I didn't know it. Wait for it.

kl3sk avatar Oct 25 '19 07:10 kl3sk