dagger-reflect icon indicating copy to clipboard operation
dagger-reflect copied to clipboard

Published 20 hours ago • verified publisher icon JakeWharton

Fix looking up generics when injecting fields in generic subclasses.

Open amatkovsky opened this issue 6 years ago • 2 comments

This pr adds a test to cover the case when there are @Inject annotated fields with type parameters. Real world example: a class BaseFragment<P extends Presenter> with a field P presenter. The fix included is just an ad-hoc solution to highlight the issue and help come up with proper fix.

amatkovsky avatar Aug 07 '19 10:08 amatkovsky

Is this a duplicate of this? https://github.com/JakeWharton/dagger-reflect/pull/129

runningcode avatar Aug 07 '19 10:08 runningcode

Is this a duplicate of this? #129

I am not sure. It looks like your pr deals with generics when resolving jit bindings while this pr is about resolving bindings for the fields. But I think your solution may be expanded to cover this case too.

amatkovsky avatar Aug 07 '19 10:08 amatkovsky