jabref

jabref copied to clipboard

Is your suggestion for improvement related to a problem? Please describe. When viewing the comments for an entry in the Comments tab, there are both "general" comments and user comments, and when user comments are visible, there is a button below prompting "Hide user comments". If that is clicked, the only way to re-enable user comments is through the settings. It is easy to misclick on, and a pain to have to re-enable when that happens.

Describe the solution you'd like It would be nice for a similar button to be available in the same Comments tab to show the user comments back more easily.

Additional context

We are on the same page: https://github.com/JabRef/jabref/issues/10424#issuecomment-1786306315

Other maintainers thought differently: https://github.com/JabRef/jabref/pull/10610#issuecomment-1787988715

Not sure how to proceed. That kind of button is the only one of that kind in JabRef. Maybe more a global library setting: https://github.com/JabRef/jabref/pull/10610#issuecomment-1787128979

Maybe another Preference: "Disable button to hide user- specific comments"? 😅

What I would suggest:

This would stay out of the way (leaving more space, as mentioned in #10424) and allow for enabling/disabling showing them in the same interface.

The buttons might be changed for icons instead maybe

but thats secondary I think.

@ror3d Thank you for your UI sketches. This way, this issue becomes a "good first issue" which can be handled by students.

Can I take this issue

setting up gitter is there an iPhone app for it? I see gitter lite and it looks different from gitter on computer

@Realmbird yo should be able to use any matrix client I guess https://app.gitter.im/#/room/#JabRef_jabref:gitter.im

currently getting student developer for github for ide, got accepted just waiting for benefits

I think the Community edition of IntellIj works well, too. Just try!

Ok

Finally got environment setup, took me time since I am open source beginner. Now I am gonna try fixing problem

@koppor @ror3d I have a question I understand I my idea of a solution is to have a show user comment button in the comment tab where the hide user comments. Also how do I get entries to check the comments for since after running JabRef I see no entries.

How does the page code work with java I tried git grep for hide user comments and not sure how the pages load with java

You need to create a new library and add entries or open an existing one

Maybe the user documentation of JabRef helps to understand the tool usage? Check https://docs.jabref.org/collect/add-entry-manually for instance.

Thanks

The existing functionality is described at https://docs.jabref.org/finding-sorting-and-cleaning-entries/comment-on-an-entry.

This issue about to move the "Hide user comments" button. In case user comments are hidden, a new button "Show user comments" should be displayed. The UI sketch is given at https://github.com/JabRef/jabref/issues/11021#issuecomment-1996994873.

I think I got it to work gonna send pull request

@koppor Check pull request https://github.com/JabRef/jabref/pull/11090

@Realmbird no need to ping at the issue, we see the pull requests. In case the PR is poperly linking the issue (which the concrete PR does), the link from the issue to the PR is established. -- I hope, your GitHub notifications work so that you saw our review comments?

Unassign me

Unassign me

@Realmbird OK. You should have been able to unassign yourself.

Additional refined requirements:

---

We should be more precise here:

1. Rename "Show user comments field" to "Show user-specific comments field" (keep "s" at the end at "comments")

Reasons:

1. It is only about the comment field of the current user, not any other user
2. It is the field specific for ("tied to") the user - not the general "comment" field

2. Rename "Hide user comments" to "Hide user-specific comments field"

Reasons: Same as for 1.

3. Rename "Show user comments" to "Show user-specific comments field"

Reasons: Same as above

4. Do NEITHER show "Show user-specific comments field" nor "Hide user-specific comments field" if user-specific comment already shown

Example for user "koppor"

Code hint: https://github.com/JabRef/jabref/pull/11090#issuecomment-2016970385

is this issue still available to work on , if yes please assign me .