J. Foederer

Results 90 comments of J. Foederer

Now I get a clear message informing me that Robot framework is not installed, plus a link to their website. Perfect!

Did you already find this document? https://github.com/robotframework/RIDE/blob/master/BUILD.rest#unit-tests

Hey Pekka, In the meantime I also joined the Slack community, where I got a bit more feel for what is going on overall with the RF developments. From that...

I still have 2 open questions about this pull request. - There are a few failing tests in the LibDoc suite. It was unclear to me if we need to...

Thanks @pekkaklarck, good review! I did what I could within the time I had available now. Not all review comments are processed yet. I hope I can spend some more...

That does indeed look ok. Good addition! Maybe be a bit careful in duplicating the dictionary or list. They can get large and draw attention away from the item actually...

> Converters could probably create converters for their values already in `__init__` similarly as `CombinedConverter` initializes `self.converters`. I was unsure how _dynamic_ the types and converters could be and when...

That would be great! I will try a Linux system with python 3.6 as well, to see what the unit test failures are about over there. I also gained some...

No problem, thanks for the update. I'll just consider it a compliment that you don't see it as a risk to integrate it that late in the process ;-) Although...

I couldn't help but notice that the original line that started this issue, is now back in the code. The one that made a specific exception for Unions, which was...