trellis-slack-webhook-notify-during-deploy icon indicating copy to clipboard operation
trellis-slack-webhook-notify-during-deploy copied to clipboard

Add deploy start & success notifications & multiple slack channel support

Open mike-sheppard opened this issue 5 years ago • 8 comments

Summary

  • Add deploy start notification #3
  • Update readme with info for newer versions of Trellis + variable name updates
  • Add git username #4
  • Add a link to the deployed site env. URL
  • Add a link to the deployed commit on GitHub for quick lookup (if using GitHub, otherwise show git sha as before)
  • Simplify message into a single line for quick scanning (after a couple deploys the longform messages cause quite a bit of scrolling)
  • Ignore errors, so deployments do not fail #8
  • Multiple Slack channels/organisations support - #9

Preview

deployment-screenshot

mike-sheppard avatar Feb 21 '20 15:02 mike-sheppard

Awesome idea!

tangrufus avatar Feb 21 '20 16:02 tangrufus

@TangRufus I've updated this a little further as Slack now doesn't allow one webhook to post to multiple channels, at least when creating a new App. My changes allow a channel to be notified per site, per environment, as well as notifying multiple channels per deploy (Mike's change). I've also moved the slack deploy token to vault. There's a PR up for @mike-sheppard here (#3) - I figured it was best to merge into his changes first but I can PR direct if that's easier.

Feedback welcome from all 👍

dalepgrant avatar Aug 03 '20 23:08 dalepgrant

@dalepgrant I'd definitely prefer merging the work from you and @mike-sheppard in one to simplify tagging the next release - so hopefully we can move forward with that.

codepuncher avatar Aug 21 '21 17:08 codepuncher

@codepuncher happy to help, let me know if you need anything more from me.

Same to you @mike-sheppard 👍

dalepgrant avatar Aug 23 '21 01:08 dalepgrant

@dalepgrant I can see that you've submitted a PR here, so I guess we'll just wait to hear back from @mike-sheppard

codepuncher avatar Aug 23 '21 07:08 codepuncher

Sure thing, that should be sorted now 👍🏻

mike-sheppard avatar Aug 23 '21 08:08 mike-sheppard

Cheers, @mike-sheppard. I'll try and get this tested this week. Thanks again for the PR!

codepuncher avatar Aug 23 '21 09:08 codepuncher

Hey @codepuncher any issues during testing? Let me know if I can do anything to get this merged in.

Nice one! Mike

mike-sheppard avatar Sep 08 '21 06:09 mike-sheppard

Note: didn't intentionally close this PR, guess it happened when we merged our forked branches.

For future ref (sorry, bit late) we ended up forking this repo to merge in a few improvements. More than happy to push it all back upstream, just shout https://github.com/smithfield-studio/trellis-slack-deploy-notifications

mike-sheppard avatar May 28 '25 07:05 mike-sheppard

Note: didn't intentionally close this PR, guess it happened when we merged our forked branches.

For future ref (sorry, bit late) we ended up forking this repo to merge in a few improvements. More than happy to push it all back upstream, just shout smithfield-studio/trellis-slack-deploy-notifications

Happy to get your changes merged upstream :)

codepuncher avatar May 28 '25 08:05 codepuncher