teams-for-linux icon indicating copy to clipboard operation
teams-for-linux copied to clipboard

Custom title bar

Open jijojosephk opened this issue 4 years ago • 8 comments

Is your feature request related to a problem? Please describe. Not related to any problem

Describe the solution you'd like Custom title bar just like the official client.

Describe alternatives you've considered No alternatives

Additional context None

jijojosephk avatar Jun 29 '21 11:06 jijojosephk

Hi @jijojosephk, do you know what to put in the custom title bar and/or how people can then customize it?

IsmaelMartinez avatar Jun 29 '21 15:06 IsmaelMartinez

@IsmaelMartinez We could make use of custom-electron-titlebar. We'll make our own if this module does not satisfy our needs. This is required especially when we have multiple tabs coming in the future implementation #438 So all the tabs (BrowserView) should be inside a container (BrowserWindow). Container will have the Tab implementation. If we're using custom title bar, we can accommodate the tabs is in title bar itself that saves some space horizontaly also it would look better.

jijojosephk avatar Jun 29 '21 15:06 jijojosephk

The module mentioned above does not satisfy our requirement. So I started a new repo here We'll add it as an npm module in teams repo.

jijojosephk avatar Jul 01 '21 03:07 jijojosephk

@IsmaelMartinez How does it look? image

jijojosephk avatar Jul 09 '21 12:07 jijojosephk

Looking good. Good job on it

IsmaelMartinez avatar Jul 10 '21 11:07 IsmaelMartinez

Hello,

Personally, I don't like the custom title bar. I totally understand why people like it, but I prefer unity between all windows.

Could you make it an option, and allow use of the default desktop manager one, like now ?

skyghis avatar Jul 13 '21 07:07 skyghis

@skyghis, Introduction of custom title bar is only to accommodate tabs #436 in a multi tenant setup. Of course, tabs can be below the title bar but it will use up extra row space which might not look good as well. This follows, google chromes's strategy. It does not follow OS's title bar. The implementation is not started yet. It's activate as a separate project as npm package here. Appreciate your suggestion, that will keep it evolving.

jijojosephk avatar Jul 13 '21 07:07 jijojosephk

Custom Titlebar would be a very nice feature. With or without the multi tennant feature

kitingChris avatar Sep 09 '21 14:09 kitingChris

Closing this as people has managed to get the multitenant working by running multiple instances, and @jijojosephk just added an appTitle so I think this is "sort of" done.

IsmaelMartinez avatar Mar 22 '23 14:03 IsmaelMartinez