ouroboros-network icon indicating copy to clipboard operation
ouroboros-network copied to clipboard

Close files uninterruptibly

Open nfrisby opened this issue 4 years ago • 2 comments

In PR #2922, @coot warns that the file-close operation is interruptible at https://github.com/input-output-hk/ouroboros-network/pull/2922#issuecomment-773218586

This Issue tracks the tech debt of further investigating and possibly addressing this. At the moment, we don't consider it a major risk because we don't rely on async exceptions much in Consensus at all or expect them to happen frequently. The current risk seems to be that a perfectly timed async exception will cause us to leak a single file handle.

nfrisby avatar Feb 16 '21 15:02 nfrisby

For some more context, Marcin blogged about the core issue here https://coot.me/posts/mask.html

nfrisby avatar Feb 22 '21 22:02 nfrisby

The upstream fix is released with ghc-9.2.

coot avatar Sep 29 '22 06:09 coot

Because this was fixed in 9.2 and we are already building the cardano-node with ghc-9.2 I think this can be closed.

coot avatar Apr 24 '23 08:04 coot