pynsee

pynsee copied to clipboard

At the moment, the _warning_OSM and _warning_search_sirene functions are used to display warnings about legal implications.

This is probably not the best way to warn users and we should discuss how to handle it (probably in the docstrings and possibly also somewhere else in the README and/or the documentation).

EDIT: regarding SIRENE, it was decided to keep the warning in the code; for OSM, "info" logging level was used so it would be good to add the license information in the documentation and docstrings

_warning_OSM could be removed as OSM data contains a column describing the Licence and OSM is mentioned in the function's doc.

_warning_search_sirene appears only once per Python session. Personal data is a sensitive topic and all users should be aware of it by default without going through package's doc. It should be considered as a warning while using logger.

Is this issue still relevant? or did we tackle all points mentioned?

Regarding OSM, we thought that an addition to the documentation and docstring of functions using it would be best; this was not done in #143

For SIRENE, I think it's fine, we kept it as a warning.