Private_Tab

Private_Tab copied to clipboard

Since https://github.com/Infocatcher/Private_Tab/commit/80b857e5cbfb80c5b6bbc4d6031bdd4ab51c27d6 the names are generated like this:

var uid = "-" + Date.now();
var id = "privateTab-key-" + kId + uid;

This produces names like privateTab-key-openNewPrivateTab-1465412089254 which change on each browser restart. This causes trouble to Keybinder because it remembers keyboard shortcuts by their uid (name). I can't tell if the timestamp is actually needed, which is why I'm asking. If removed, use of the addon would be a possible solution to https://github.com/Infocatcher/Private_Tab/issues/193.

IIRC, without unique ids Firefox won't update hints after labels of menu items (may be only in old Firefox versions or only in Mac OS). Anyway, due to limitations of built-in items - there is only fake things, that used only for native hints.