InfiniTime

InfiniTime copied to clipboard

Added a new check that displays clang-tidy warnings for changed files. This check isn't blocking, because a lot of warnings exist in the codebase and the rules may need to be tweaked, but can be used for reference. I've added some fixes that trigger the check for demonstration.

I think we should work to fix these warnings or disable them if they're not important. These warnings aren't necessarily about fixing bad code, but rather consistent practices, so silencing or switching some of them isn't an issue. Let me know what you think.

This has always been the end intention, that ideally a new PR would see if any additional warnings are generated and the author has a chance to fix them.

@JF002 Yes. They fix a few warnings and trigger the check on those files, so we can inspect it.

Ok, great! And I've just noticed that the PR also adds a new github workflow to run clang-tidy :+1: This could be extended in the future to export the warning messages in a build artifacts, a bit like it's done in the clang-format workflow!