Nuklear icon indicating copy to clipboard operation
Nuklear copied to clipboard

Rename null texture field to name friendlier to language bindings

Open ryuukk opened this issue 3 years ago • 3 comments

"null" is a reserved keyword in most languages, to make the usage of the library easier for other languages (and other compilers zig/D), let's rename it, it also is a better name in my opinion, null should be reserved in C too imo

ryuukk avatar Jun 26 '22 22:06 ryuukk

Looks OK to me on the first glance.

Could someone else please review this? Maybe also @Hejsil as a Zig expert :wink:?

dumblob avatar Jul 05 '22 13:07 dumblob

As for Zig, @"null" can be used for variable, field, function and declaration names, so it is not really a problem as long as Zig's auto translation tools actually does the correct thing. Idk about other languages, though, so this might still be a necessary change,

Hejsil avatar Jul 09 '22 17:07 Hejsil

@ryuukk ok, please bump the version (the third number only) to not break any build pipelines expecting that each release has a corresponding unique version string and then we will merge this :wink:. Thanks!

dumblob avatar Sep 06 '22 14:09 dumblob