igniteui-angular-samples

igniteui-angular-samples copied to clipboard

Description

Previously we had to set a fixed heights in order for the Grid to fit the iframe, but now the iframe is sized based on the codeview container and its okay to set grid's height and its parent element to be with height:100% in order to take the full size within the code view and at the same time be with full screen size when opened alone.

Example with CRM Grid:

Full screen:

@hanastasov, for the time being please make only this sample app with 100% height in order to unblock the marketing team for their video campaign: https://www.infragistics.com/angular-demos/hierarchical-grid/hierarchical-grid-toolbar-pinning

@monacodelisa I should have defined the acceptance criteria better, the expected result is the grid to take the full window width. It looks like setting height to 100% is not enough in that case:

Also @monacodelisa please add one more thing, the marketing team would love to have theme switcher on the sample in order to open it in dark mode. We already have a sample that is doing so, example below. Use it as a reference to achieve it for the hierarchical-grid-toolbar-pinning.

White: https://www.infragistics.com/angular-demos-grid-crm Dark: https://www.infragistics.com/angular-demos-grid-crm/?dark=true

@hanastasov would it be possible to consider adding the dark theme switch capabilities to all angular samples? I guess it might be challenging in order to came up with at idea that covers all samples, but the time spend on this will pay in the future as the marketing team will continue using our sample for their campaigns.

White: https://www.infragistics.com/angular-demos-grid-crm Dark: https://www.infragistics.com/angular-demos-grid-crm/?dark=true

Nice idea, logged it for current sprint. https://github.com/IgniteUI/igniteui-angular-samples/issues/3256

When I drill down, there is a lot of empty space (not showing many columns).

Can we apply a theme to this sample so it has more color, or dark theme would be fine. Thanks

I am removing this item from the sprint, we have other priorities to focus on and probably will get back to it some of the upcoming iterations