label-studio icon indicating copy to clipboard operation
label-studio copied to clipboard

feat: jsonL support

Open Jorjeous opened this issue 1 year ago • 6 comments

PR fulfills these requirements

  • [+] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • [-] Tests for the changes have been added/updated (for bug fixes/features)
  • [-] Docs have been added/updated (for bug fixes/features)
  • [-] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • [+] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • [ ] Product design
  • [ ] Backend (Database)
  • [ ] Backend (API)
  • [ ] Frontend
  • [+] OtherBackend

Describe the reason for change

(link to issue, supportive screenshots etc.) People often confuse json and jsonL The nemo framework deliberately uses the name json, although in fact it is jsonL

What does this fix?

(if this is a bug fix)

What is the new behavior?

(if this is a breaking or feature change) Ability to import jsonL

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes) No

Does this change affect performance?

(if so describe the impacts positive or negative) No

Does this change affect security?

(if so describe the impacts positive or negative) No

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • [ ] Yes, and covered entirely by feature flag(s)
  • [ ] Yes, and covered partially by feature flag(s)
  • [+] No
  • [ ] Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • [ ] e2e
  • [ ] integration
  • [ ] unit
  • [+] Manual

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.) Data import

Jorjeous avatar May 06 '24 16:05 Jorjeous

Deploy request for label-studio-docs-new-theme pending review.

Visit the deploys page to approve it

Name Link
Latest commit e41bb8e434187a3968b7bfde301dd9f92afa6aa9

netlify[bot] avatar May 06 '24 16:05 netlify[bot]

Deploy request for heartex-docs pending review.

Visit the deploys page to approve it

Name Link
Latest commit e41bb8e434187a3968b7bfde301dd9f92afa6aa9

netlify[bot] avatar May 06 '24 16:05 netlify[bot]

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: label_studio/data_import/models.py

Function Unhandled Issue
read_tasks [**ValidationError: "Failed to parse input file upload/64275/1870f275-dic2023_traducido.csv: 'utf-8' codec can't dec...** ...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

sentry-io[bot] avatar May 06 '24 16:05 sentry-io[bot]

/jira create

Workflow run Jira issue TRIAG-550 is created

sajarin avatar May 08 '24 19:05 sajarin

After that pr I'm going to add

  1. some new default templates (Automatic Speech Recognition (ASR) with ground truth (GT), ASR + GT + model prediction )
  2. scripts for cutting long audios to small jobs using NFA (Nemo Forced Aligner)
  3. template for long audio, that utilizes ML backend, and java script, that follows text (according to the audio)

Jorjeous avatar Jun 04 '24 16:06 Jorjeous

thanks for the PR @Jorjeous, our team is working through some PRs and we'll have a review for this one soon, thanks for being patient!

related reports for jsonL support: https://github.com/HumanSignal/label-studio-converter/issues/58 https://github.com/HumanSignal/label-studio/issues/1960 https://github.com/HumanSignal/label-studio/issues/4607

sajarin avatar Jun 10 '24 19:06 sajarin

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

robot-ci-heartex avatar Aug 03 '24 01:08 robot-ci-heartex

This PR was closed because it has been stalled for 10 days with no activity.

robot-ci-heartex avatar Aug 13 '24 01:08 robot-ci-heartex