label-studio

label-studio copied to clipboard

These are changes to support SAS token authentication patterns for Azure storage options. The changes include UI and database schema changes to support the storing of these tokens.

SAS tokens are an alternative way of enabling access for containers in Azure. This is a pattern that should be an option.

More information on SAS tokens are available here: https://docs.microsoft.com/en-us/azure/storage/common/storage-sas-overview

@farioas @makseq requesting your review. many thanks

@smoreface could you please check the descriptions here?

@marcjimz thanks so much for making the documentation updates along with your PR, it's super appreciated!! I added some suggestions to simplify the language and fix typos. I'll take another look after those suggestions are implemented :)

Thanks all for the prompt reviews. Looking forward to this change making the next release. I contributed the latest changes and tested on my local for SAS key implementation, works well. Question remains on the splitting of client container method, if this group here is OK with the format.

Hi all - this has grown stale. Can we merge this?

Please remove all new docker-compose values, as there only one configuration difference:

      - AZURE_BLOB_ACCOUNT_NAME=uedlabsdevbluezone
      - AZURE_BLOB_SAS_TOKEN=sp=racwdl&st=2022-01-27T18:15:47Z&se=2022-02-01T02:15:47Z&spr=https&sv=2020-08-04&sr=c&sig=lSwo9oaEf1bSbThayiQA9uRybhJSRfcILZ0GITqMuEU%3D
      - AZURE_BLOB_CONTAINER=ee7163bd-6915-48f8-a0e2-892deda02cd2

And add the information about SAS tokens as a separate paragraph under ## Microsoft Azure Blob storage to docs/source/guide/storage.md

Any progress on this PR? We are interested in using label studio but this is a real blocker as using access keys violates or security guidelines. Thanks a lot for the update.

This PR is stale because it has been open 172 days with no activity. Remove stale label or comment or this will be closed in 10 days.

This PR was closed because it has been stalled for 10 days with no activity.