open-builder icon indicating copy to clipboard operation
open-builder copied to clipboard

Moire Effect

Open Hopson97 opened this issue 5 years ago • 4 comments

Bug Name

Moire Effect

Describe the bug

When looking in the distant, sometimes circles can appear on the terrain

To Reproduce

Just looks at things far away

Screenshots

Screenshot_20200113_065323

Desktop (please complete the following information):

  • OS: Windows 10, Ubuntu LTS

Additional context

Possibly caused by wacky texture parameters on the Texture Array object (found in src/client/gl/textures.cpp)

Hopson97 avatar Jan 13 '20 06:01 Hopson97

This is not a bug per se, but an artifact that is caused by geometry aliasing. There is nothing you could do in the texture tweaking to solve this.

UglySwedishFish avatar Jan 13 '20 12:01 UglySwedishFish

As an additional pointer to this, if you really want to get rid of it I could attempt a rewrite of the entire rendering pipeline. But I don't think you're going to like the additional work you're going to have to do when you want to add additional simple things (like waving plants)

UglySwedishFish avatar Jan 13 '20 12:01 UglySwedishFish

Possible ways to dodge the issue:

  • use a different set of simpler textures for blocks >150 blocks away (probably will look worse)
  • use something like minecraft optifine's connected textures, use the top all-green texture on the side of grass blocks when there is another grass block 1 unit to the side and 1 unit down image
  • for steep/high altitude terrain, generate a simpler textured block on the surface, like stone

redinator2000 avatar Jan 13 '20 21:01 redinator2000

I believe simple MSAA can fix this issue.

rehwinkel avatar Jan 20 '20 07:01 rehwinkel