otel-k8s

otel-k8s copied to clipboard

Hi! How are you? Hope you're fine! I was using your repository to start a demonstration and notice that there are some errors at the end of the README.md file.

• The kubectl apply command accepts directories. If we use /* as it is, it will give an error like the following:

  error: Unexpected args: [load-generators/deployment.yaml load-generators/main.go load-generators/service.yaml]

• The folder in the repository is load_generators and not load_generator.

I tried to push to a new branch in order to open a PR, but I do not have permission to do so. Thus, I'm sending here my suggestion:

- kubectl apply -f load-generator/*
+ kubectl apply -f load-generators 
- kubectl apply -f otel-agent/*
- kubectl apply -f otel-collector/*
- kubectl apply -f jaeger-all-in-one/*
- kubectl apply -f zipkin-all-in-one/*
- kubectl apply -f prometheus/*
+ kubectl apply -f otel-agent
+ kubectl apply -f otel-collector
+ kubectl apply -f jaeger-all-in-one
+ kubectl apply -f zipkin-all-in-one
+ kubectl apply -f prometheus

Your repo is super nice and it helped me a lot to understand some concepts. The goal here is just to improve the README.md. Thank you!

Incredibly sorry that I'm seeing this now, never intended to keep this maintained. However I think the repo needs a refresh with latest versions updated. Give me a few days to get that done.

Incredibly sorry that I'm seeing this now, never intended to keep this maintained. However I think the repo needs a refresh with latest versions updated. Give me a few days to get that done.

No worries! Thank you so much for your reply!