almanac.httparchive.org icon indicating copy to clipboard operation
almanac.httparchive.org copied to clipboard

2022 Media Chapter

Open eeeps opened this issue 3 years ago • 1 comments

Closes #2884

Staging link: https://20220922t004911-dot-webalmanac.uk.r.appspot.com/en/2022/media Home page quotes: https://20220922t004911-dot-webalmanac.uk.r.appspot.com/en/2022/?feat=media#featured-chapter

Still need to:

  • [x] Add figure fallback image urls (@tunetheweb has a magic script for this?)
  • [ ] Add figure descriptions
  • [ ] Add featured stats and quotes
  • [ ] Couple of inline todos...
  • [ ] One or two more readthroughs to make sure markdown conversion went as it should.

eeeps avatar Sep 21 '22 22:09 eeeps

I ran my magic script and added the images. Also did some light editing.

Staged URL here: https://20220922t004911-dot-webalmanac.uk.r.appspot.com/en/2022/media (note this does not auto update but ping me if you want it updated).

tunetheweb avatar Sep 21 '22 23:09 tunetheweb

How we looking @eeps? We'll need this all complete by tomorrow (ideally today!) if we want to include in Monday's release.

tunetheweb avatar Sep 23 '22 10:09 tunetheweb

@tunetheweb Just added the featured quotes and gave it one more read-through; I think it's ready to merge.

eeeps avatar Sep 24 '22 17:09 eeeps

(we'll see if the linter agrees here in a minute or two)

eeeps avatar Sep 24 '22 18:09 eeeps

Did a few more tweaks and now I think it's really, actually ready to merge.

eeeps avatar Sep 24 '22 20:09 eeeps

Thank you!!

One change I want to confirm, the Images section intro now reads:

We see from the Media chapter

I think that should still say "Page Weight"?

eeeps avatar Sep 25 '22 14:09 eeeps

Other than that the edits you made make total sense and it looks fantastic. Thank you!

eeeps avatar Sep 25 '22 14:09 eeeps

Thank you!!

One change I want to confirm, the Images section intro now reads:

We see from the Media chapter

I think that should still say "Page Weight"?

Doh! Head non screwed on correctly. Fixed now. Will merge after CI finishes.

tunetheweb avatar Sep 25 '22 14:09 tunetheweb