parjs icon indicating copy to clipboard operation
parjs copied to clipboard

Make "engines" less restrictive in package.json

Open matlin opened this issue 1 year ago • 1 comments

The current engines field seems pretty arbitrary. ES2020 (specified in tsconfig) fully landed in Node14 but setting it to Node16 to be conservative.

matlin avatar May 21 '24 17:05 matlin

@GregRos I'm not sure but it looks like you added the engines in 667580f1. Do you remember if there was a reason for choosing the current engines?

mikavilpas avatar May 21 '24 17:05 mikavilpas

Thank you! <3

I've merged this into #119 manually. I'm working on it now.

@GregRos I'm not sure but it looks like you added the engines in 667580f. Do you remember if there was a reason for choosing the current engines?

There is the testing issue. Like, the difference between 20 and 16 might be big enough we should have separate tests for 16. That sounds kind of annoying. But a lot of people do use 16 for various reasons. Sooo let's just set it to 16 and that's it.

The specific versions just came from some other package that I copied. If there is a special reason for those, I don't know what it is. 🤷‍♂️

GregRos avatar Jun 05 '24 22:06 GregRos