Gravis

Well, it's the same reason: license incompatibility. [spdlog is MIT](https://github.com/gabime/spdlog?tab=License-1-ov-file#readme) and [gtest is BSD-3](https://github.com/google/googletest?tab=BSD-3-Clause-1-ov-file#readme) which are both incompatible with the GPL. Note that zlib license is a permissible license which...

> I don't see value of these changes. That's your mistake because there are currently significant issues open that are likely due to memory access issues.

The purpose of the changes are to ensure that if a memory violation occurs that it will immediately be caught rather than continue, possibly crashing at a later point. I...

@winterheart Do you not want bugfixes? This contains bugfixes.

> `std::array` doesn't perform bounds checking via its iterators or `operator[]` The C++ standard doesn't not specify the behavior of accessing nonexistent elements using `operator[]`. However, common implementations like [GCC's...

In my professional opinion we should be including `PROJECT_SOURCE_DIR` and using `"subproject/headerfile.h"` for includes. Using a common point of origin (`PROJECT_SOURCE_DIR`) would eliminate the need for adding `target_include_directories` directives. As...

@Lgt2x I've done everything I can to appease @winterheart but he still insists I remove the listed header files, knowing that this will harm my ability to work on the...

@winterheart @Lgt2x Hey, what's the deal?

> First pass, some small adjustments to make, but good job otherwise. I'd still like a second pair of eyes to review this thoroughly, changes to the build system are...

@Lgt2x After investigating the issue, I'm not seeing how the linux version managed to work before. The static `Database` pointer value is initialized as `NULL` and `dbase` uses that as...