Camera icon indicating copy to clipboard operation
Camera copied to clipboard

Add support for setting video frame rate

Open MHShetty opened this issue 1 year ago • 5 comments

Adds support to set fps of the video being recorded (Issue #51)

(Needs testing to check if the set fps actually reflects in the video across different devices, especially at 60 fps for devices that support it)

MHShetty avatar Jun 07 '24 18:06 MHShetty

The video frame rate despite being set correctly doesn't seem to reflect on the video currently. We could merge this PR once this gets resolved on CameraX

MHShetty avatar Jul 19 '24 09:07 MHShetty

The latest changes made in the recent release does fix the issue with uncertainties with lower ranges on my Pixel 7A. However, the issue still persists for 60 fps, where recording a video while choosing a 60-fps range (from the list of supported ranges reported by the library) doesn't make the fps of the recorded video close to the selected range.

Have filed an issue for the same on CameraX's issue tracker: https://issuetracker.google.com/issues/384146331

MHShetty avatar Dec 14 '24 22:12 MHShetty

We might finally be able to have this feature in our app by the next CameraX release

MHShetty avatar Jun 03 '25 16:06 MHShetty

A fix is available for this in the latest release: https://issuetracker.google.com/issues/384146331#comment20

Will update this PR for the same once its implemented and tested on our end

MHShetty avatar Jul 24 '25 08:07 MHShetty

We have found some issues with the new API, could take a while before it gets resolved. Might need to drop persistency to support varying combinations of video settings correctly

MHShetty avatar Jul 25 '25 03:07 MHShetty