Graham

Results 164 comments of Graham

Seems reasonable to me! It may be as simple as updating the target path here: https://github.com/icsharpcode/CodeConverter/blob/29deb717749836f5d2c2d733e81fe08761df6251/CodeConverter/CSharp/VBToCSProjectContentsConverter.cs#L82-L85

Yes I think adding them as additional documents (like resx) would be the correct thing to do. There isn't any other existing way to track non-code files, so if it...

Yep, seems sensible to me. I haven't really tested aspx conversion so far. If you see any other changes related to aspx feel free to add them here too.

When I investigated ".asp" files I can't remember if I checked for aspx/ascx. But just linking to my comment at the time for reference: https://github.com/icsharpcode/CodeConverter/issues/160#issuecomment-416369476 In particular: https://docs.microsoft.com/en-us/dotnet/api/system.web.compilation.buildprovider?redirectedfrom=MSDN&view=netframework-4.7.2 may be...

I've just had a brief look into this. It turns out that Roslyn creates a separate project within the solution object for each aspx file. The project contains a single...

1\) Yep we'd definitely need to check/refine the behaviour there. I think it's possible to get the nested files, and the menu may even already correctly appear because of them....

Good finds - not great news for an already difficult feature, but good to know in advance

Thanks! I'll have to experiment with this one a bit to understand what's going on I hadn't come across [`DynamicAttribute`](https://docs.microsoft.com/en-us/dotnet/api/system.runtime.compilerservices.dynamicattribute.-ctor?view=net-6.0#System_Runtime_CompilerServices_DynamicAttribute__ctor_System_Boolean___) before. But it looks completely equivalent to the C# version...

Lots of dynamic related stuff will likely be solved with the same change, feel free to add more examples of you find them, but this one is definitely good for...

Yeah that one is a slightly tricky decision. My sense is that most VB apps wouldn't use the thread safety, but obviously when it does matter it can be really...