Graham Campbell

Results 563 comments of Graham Campbell

PHPDotenv already natively supports loading more than one file. Why can't you just load a base file and then a file specific to the environment you have?

I'd not recommended to parse the file over and over. Use config caching. :)

The line you link to is the line that basically does all of the parsing, btw. ;)

Yes, definitely. Run both config and route cache, with the env set to testing.

This is a major breaking change. I think this would require a new PSR?

@jasny Because this PR could be considered a change to the spec, and is certainly a major breaking change to the interface. There was discussion over if a new PSR...

> If other people uses wrong dependency version strings (e.g. *), then that is their fault. SemanticVersioning FTW. Well, this was on a virtual package, which has no versions.

> I think, our discussion go to wrong way. I don't agree. The PSR Amendments Bylaw doesn't allow changing the signature of interfaces, which blocks this PR: https://www.php-fig.org/bylaws/psr-amendments/.

👎 Newer PHP does allow this method to throw an exception.

Maybe an approach like symfony and laravel do will suit better. That is, the readonly packages are auto-split from the main repo, so you can keep working on one repo.