skaffold icon indicating copy to clipboard operation
skaffold copied to clipboard

skaffold doesn't support upgrade schema for kustomize project with buildArg

Open ericzzzzzzz opened this issue 3 years ago • 1 comments

while running skaffold render with v2beta29 schema for an kustomize project

apiVersion: skaffold/v2beta29
kind: Config
deploy:
  kustomize:
    buildArgs:
      - "-o fail.yaml"

got this error :

parsing skaffold config: error parsing skaffold configuration file: transforming skaffold config: upgrading main pipeline: converting deploy.kustomize.buildArgs isn't currently supported

it looks like that skaffold doesn't support buildArg upgrade for kustomize on purpose. However, when running skaffold render with the newest schema,

apiVersion: skaffold/v3alpha1
kind: Config
manifests:
  kustomize:
    paths:
      - .
    buildArgs:
      - "-o abc.yaml"

everything works perfectly.

Expected Behavior

  • not sure what is the expected behavior, if the new config provided above works, why skaffold doesn't support upgrade buildArg?

Actual Behavior

  • skaffold failed to upgrade schema for kustomize project with buildArg

Information

  • Skaffold version:
  • Operating system:
  • Installed via:
  • Contents of skaffold.yaml:

Steps to reproduce the behavior

  1. run skaffold render -f skaffold-kustomize-upgrade-fail.yaml in this project https://github.com/ericzzzzzzz/skaffold/tree/bug-bash-testing/examples/kustomize
  2. should see this error
parsing skaffold config: error parsing skaffold configuration file: transforming skaffold config: upgrading main pipeline: converting deploy.kustomize.buildArgs isn't currently supported

ericzzzzzzz avatar Jul 22 '22 17:07 ericzzzzzzz

@marlon-gamez could you provide more insights on this one?

ericzzzzzzz avatar Jul 22 '22 18:07 ericzzzzzzz

The issue was fixed with a previous PR. We did a couple of tests, and it no longer appears; the error message does not appear, and the output is generated in the specified .yaml file

renzodavid9 avatar Sep 29 '22 19:09 renzodavid9