java-docs-samples icon indicating copy to clipboard operation
java-docs-samples copied to clipboard

docs(secretmanager): Added sample for creating Secret with UserManaged replication

Open kapishps opened this issue 3 years ago • 0 comments

Added sample for creating Secret with UserManaged replication

Fixes b/222386112

It's a good idea to open an issue first for discussion.

  • [x] I have followed Sample Format Guide
  • [ ] pom.xml parent set to latest shared-configuration
  • [ ] Appropriate changes to README are included in PR
  • [x] API's need to be enabled to test (tell us)
  • [x] Environment Variables need to be set (ask us to set them)
  • [x] Tests pass: mvn clean verify required
  • [x] Lint passes: mvn -P lint checkstyle:check required
  • [ ] Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • [ ] Please merge this PR for me once it is approved.

kapishps avatar Jul 25 '22 20:07 kapishps

@alicejli @java-samples-reviewers please review this PR

kapishps avatar Aug 24 '22 07:08 kapishps

Hi @alicejli , I have rewritten the sample to maintain uniformity across other languages (others have been merged recently). Please have a look once again.

kapishps avatar Aug 28 '22 20:08 kapishps

@alicejli Thanks for approving. Please merge the PR, somehow I don't have write access so I'm unable to merge it.

kapishps avatar Sep 05 '22 07:09 kapishps