java-docs-samples

java-docs-samples copied to clipboard

Added samples to move instances across zones (https://cloud.google.com/compute/docs/instances/moving-instance-across-zones)

Apologies for the PR size.

Here is the summary of changes.

You are about to add 11 region tags.

• compute/cloud-client/src/main/java/compute/CreateInstanceWithExistingDisks.java:17, tag compute_instances_create_with_existing_disks
• compute/cloud-client/src/main/java/compute/GetInstance.java:17, tag compute_instances_get
• compute/cloud-client/src/main/java/compute/disks/CreateDiskFromImage.java:17, tag compute_disk_create_from_image
• compute/cloud-client/src/main/java/compute/disks/CreateDiskFromSnapshot.java:17, tag compute_disk_create_from_snapshot
• compute/cloud-client/src/main/java/compute/disks/CreateEmptyDisk.java:17, tag compute_disk_create_empty_disk
• compute/cloud-client/src/main/java/compute/disks/CreateSnapshot.java:17, tag compute_snapshot_create
• compute/cloud-client/src/main/java/compute/disks/DeleteDisk.java:17, tag compute_disk_delete
• compute/cloud-client/src/main/java/compute/disks/DeleteSnapshot.java:17, tag compute_snapshot_delete
• compute/cloud-client/src/main/java/compute/disks/ListDisks.java:17, tag compute_disk_list
• compute/cloud-client/src/main/java/compute/disks/ListSnapshots.java:17, tag compute_snapshot_list
• compute/cloud-client/src/main/java/compute/disks/SetDiskAutodelete.java:17, tag compute_disk_autodelete_change

---

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

• [ ] Refresh this comment

Thank you very much for the samples @Sita04 , these looks great 😃

Just a few thoughts:

• I see that there are multiple different actions that are part of this PR. I feel like it will make it easy on the reviewers if this was broken into multiple PRs.

  • Get instance
  • ListDisks, CreateEmptyDisk, DeleteDisk
  • CreateWithDisks, CreateDiskFromImage, CreateDiskFromSnapshot
  • ListSnapshots, CreateSnapshot, DeleteSnapshot
  • SetDiskAutodelete

• Breaking up the PR will also ensure that important details of the PR are not overlooked by the reviewers

• Also, was the expectation to write a specific sample to showcase instance migration to a new zone? I looked around and couldn't exactly find a specific sample that shows this action.

Let me know what you think.

Thanks for the review, @Shabirmean :)

Agree with the PR splitting strategy. Would be easier for the reviewers. I will be more careful the next time. Thanks for pointing it out.

the expectation to write a specific sample to showcase instance migration to a new zone?

Yes, these samples represent a collection that could be used in the doc under moving VM instances page. They do not refer to a sample on how to move instances. Please refer to this bug for more info: b/202504009

@Shabirmean Thanks for the review. I've incorporated your suggestions. PTAL.