link-to-text-fragment icon indicating copy to clipboard operation
link-to-text-fragment copied to clipboard

Does not work on Firefox anymore

Open Qhilm opened this issue 2 years ago • 10 comments

Currently, the only way to get it to work on Firefox is:

  1. load the link to text fragment
  2. it fails
  3. click on the "link to text fragment" add-on icon
  4. Error is displayed "INVALID_SELECTION: The selection provided could not be used."
  5. reload web page in Firefox
  6. it works, text fragment is highlighted.

These steps must be repeated for every link, hence it's not very usable anymore.

Example link: https://blog.chromium.org/2019/12/chrome-80-content-indexing-es-modules.html#:~:text=ECMAScript%20Modules%20in%20Web%20Workers

Firefox 117.0.1 macOS 13.5.2

Qhilm avatar Sep 14 '23 06:09 Qhilm

I'm not sure what changed on the Firefox side. It was working just fine, but I can confirm that it stopped working on Firefox 117 now. It uses manifest v3, so maybe there's some problem there? You can see the recent commits if you want to investigate.

There's a known issue on Chrome (and probably Firefox), where extension contexts can't use the Async Clipboard API because it's not focused. In Chrome, this is tracked as https://crbug.com/1404835.

tomayac avatar Sep 14 '23 08:09 tomayac

https://github.com/GoogleChromeLabs/link-to-text-fragment/issues/95#issue-1895851565

@Qhilm, it has worked for me using https://download.opensuse.org/repositories/openSUSE:/Factory/standard/x86_64/MozillaFirefox-122.0-3.2.x86_64.rpm on cpe:/o:opensuse:tumbleweed from :20230915 to :20240131.

  1. https://github.com/GoogleChromeLabs/link-to-text-fragment/assets/42837531/a790f05a-b275-47cc-88ce-e8eec0f5a8f7

  2. Screenshot_20230919_185952

RokeJulianLockhart avatar Sep 19 '23 18:09 RokeJulianLockhart

Firefox 119 on macOS Sonoma. I no longer see the "Copy link to selected text" context menu item.

johnmaguire avatar Nov 03 '23 14:11 johnmaguire

Firefox 119 on macOS Sonoma. I no longer see the "Copy link to selected text" context menu item.

you may have to click on the add-on icon once.

Qhilm avatar Nov 03 '23 14:11 Qhilm

Seems to be working without any additional steps for me on Windows firefox 121.0.1 (64-bit)

budak7273 avatar Jan 27 '24 20:01 budak7273