comlink-loader icon indicating copy to clipboard operation
comlink-loader copied to clipboard

Ensuring TypeScript types are correct

Open fabiospampinato opened this issue 5 years ago • 3 comments

async functions can't return primitives, anything that gets returned must be wrapped in a promise.

fabiospampinato avatar Sep 14 '20 18:09 fabiospampinato

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Sep 14 '20 18:09 googlebot

I'm being asked by the bot to sign the CLA, but upon signing it I get this error: "It looks like you've already signed this CLA." so 🤷‍♀️

fabiospampinato avatar Sep 14 '20 18:09 fabiospampinato

Will this be merged anytime soon?

DerZade avatar Feb 11 '22 20:02 DerZade

Closing for cleanliness, as I'm not interested in this anymore.

fabiospampinato avatar Aug 29 '23 01:08 fabiospampinato