lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard

Use page other than `chrome://terms` for bf-cache gatherer

Open connorjclark opened this issue 2 years ago • 7 comments

https://github.com/GoogleChrome/lighthouse/blob/1d2a380d3c15e5848381fc1dd625837c5dc28ff6/core/gather/gatherers/bf-cache-failures.js#L107-L109

Marking for 11.0 not because it is a breaking change, but to keep on our radar to check on "sometime in the future".

connorjclark avatar Jan 11 '23 21:01 connorjclark

CDT still uses the terms page: https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/front_end/panels/application/components/BackForwardCacheView.ts;l=249;drc=091da104d0b774fc03a50d63954565986b197369

connorjclark avatar Jul 06 '23 16:07 connorjclark

Using about:blank as the temp page still adds an extra "Internal error" when testing bfcache. I'll ping bfcache folks about this again.

@tunetheweb chrome://blank isn't a valid page unfortunately. Do you know any other chrome://xyz pages that might be less confusing to users but still avoid the bugs we see with about:blank.

adamraine avatar Jul 06 '23 18:07 adamraine

Yeah I was suggesting getting the Chrome team to add that page. Not sure of any that would be less confusing to be honest.

tunetheweb avatar Jul 06 '23 18:07 tunetheweb

chrome://print/ maybe?

tunetheweb avatar Jul 06 '23 18:07 tunetheweb

Coming from #15223, I was now trying to search about why do I see that page on every test! Now I understand :) It's indeed confusing to us.

ghnp5 avatar Apr 27 '24 03:04 ghnp5

Is this affecting the LCP metric? My page loads in ~1s but the LCP reports ~10s

pladaria avatar May 29 '24 10:05 pladaria

No, LCP is measured as a separate audit before this one.

tunetheweb avatar May 29 '24 10:05 tunetheweb