developer.chrome.com icon indicating copy to clipboard operation
developer.chrome.com copied to clipboard

Add Web SQL deprecation article

Open tomayac opened this issue 3 years ago • 8 comments

Fixes https://github.com/GoogleChrome/developer.chrome.com/issues/3323

Changes proposed in this pull request:

  • Add the article.

Staging preview

tomayac avatar Aug 01 '22 16:08 tomayac

Deploy Preview for developer-chrome-com failed.

Name Link
Latest commit 11da0465baa63801b32f304200c45bae14d3f085
Latest deploy log https://app.netlify.com/sites/developer-chrome-com/deploys/630f887123165f00099910e7

netlify[bot] avatar Aug 01 '22 16:08 netlify[bot]

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

site/en/blog/deprecating-web-sql/index.md

  • Please change your usage of the following words:
    • Avoid please. Affected lines: 211

Thanks, @jpmedley! Let's still give @morsssss a chance to review before we push this live.

tomayac avatar Aug 02 '22 15:08 tomayac

Putting this on hold until @morsssss and I have had a chance to talk.

tomayac avatar Aug 05 '22 14:08 tomayac

@morsssss, I have reworded this article based on what we discussed during our meeting. PTAL! Here's the staging preview.

tomayac avatar Aug 12 '22 09:08 tomayac

@morsssss, are you completely done with your review?

jpmedley avatar Aug 12 '22 14:08 jpmedley

Ben wants to loop this over to the eng team as well. We want to make sure this lands well.

tomayac avatar Aug 12 '22 15:08 tomayac

I will wait for his team to finish their review.

jpmedley avatar Aug 12 '22 17:08 jpmedley

@tomayac I added back the "do not merge' label. I need to glance over the text one more time now that Ben is done with it.

jpmedley avatar Aug 31 '22 15:08 jpmedley