mini-runner icon indicating copy to clipboard operation
mini-runner copied to clipboard

#4 add priority to add/remove methods

Open drkibitz opened this issue 8 years ago • 2 comments

  • tweaks to benchmark script

PR for https://github.com/GoodBoyDigital/mini-runner/issues/4

Will support https://github.com/pixijs/pixi.js/issues/3835

drkibitz avatar Mar 19 '17 03:03 drkibitz

My goal was to make these changes, while matching the benchmarks in master, and clearly an extra object lookup is losing some speed. I think I'll just go with two arrays. With the changes as they are now, these are the benchmarks, I'll post more with the new changes.


Master runs:

runner is 28.98512482214446x faster than signals
runner is 3.755012288190379x faster than mini-signals
runner is 1.9605484413400571x faster than events
runner is 20.991564417178157x faster than signals
runner is 2.896472392638069x faster than mini-signals
runner is 1.5404524539877502x faster than events
runner is 31.183298245614044x faster than signals
runner is 4.413192982456136x faster than mini-signals
runner is 2.16912280701754x faster than events

Branch runs:

runner is 14.704808197582972x faster than signals
runner is 2.257159747766721x faster than mini-signals
runner is 1.1426037834997573x faster than events
runner is 14.418048008803964x faster than signals
runner is 2.277254281587465x faster than mini-signals
runner is 1.2248435243139189x faster than events
runner is 13.799511002444985x faster than signals
runner is 2.1779554615740455x faster than mini-signals
runner is 1.1434613097204727x faster than events

drkibitz avatar Mar 19 '17 05:03 drkibitz

Ok, got it, now these are the benchmarks... There does seem to a be a tiny fraction of more consistency with the reverse while loop, but nothing really measurable from my runs. So this is my PR for now, same performance, but with listener priority order!

Master:

runner is 24.417149193051596x faster than signals
runner is 3.5712701737094963x faster than mini-signals
runner is 1.9508439078477295x faster than events
runner is 23.845164012235127x faster than signals
runner is 3.3134690433498717x faster than mini-signals
runner is 1.6721864782196056x faster than events
runner is 22.15885099472199x faster than signals
runner is 3.2657328461226234x faster than mini-signals
runner is 1.6549939098660271x faster than events

Branch:

runner is 23.18400737412169x faster than signals
runner is 3.678188731420716x faster than mini-signals
runner is 2.0129047125245147x faster than events
runner is 22.975447909754457x faster than signals
runner is 3.706038487060376x faster than mini-signals
runner is 2.061601415616021x faster than events
runner is 23.950111138552863x faster than signals
runner is 3.965547048654x faster than mini-signals
runner is 2.1500370461842615x faster than events

drkibitz avatar Mar 19 '17 06:03 drkibitz