Gingeh
Gingeh
> I would have liked to see more commits though. This seems to be a big bag of improvements, that could have been split. Yeah that's definitely something I need...
I've realised that the loop in `StyleComputer::compute_style_impl` doesn't descend into value lists, so `background-position: left, right` isn't computed/serialized properly. (and the way the shorthand is implemented means `x1 y1, x2...
Updated to compute and correctly serialize `background-position`s with many layers. I'm still unconvinced that computing in `StyleProperties` would be more correct than in `StyleComputer` (for reasons explained on discord).
Updated to resolve a conflict and to remove an unnecessary special case for `background-position` in `ResolvedCSSStyleDeclaration` which caused the `background` shorthand's initial position to serialise incorrectly.
Very good! Could it be worth adding a test for this?
This crash now happens while loading the page, without any further input.
I suppose you'll want me to rewrite #2651 to use this.
The steps you've changed are implemented directly from the specification (https://html.spec.whatwg.org/multipage/dom.html#document.title, linked above the method), usually when we differ from the specification we leave the instructions as-is and leave a...
Yeah that's a lot better :)