Prism
Prism copied to clipboard
Ignore style guide ids
Hi,
We want to be able to not fetch certain style guides, in our workspace we use the same naming in multiple style guides. Because of this, we want to be able to skip the fetching of certain style guides.
To accomplish this I've added the option to the configuration, so this is now possible. Hopefully, this can be added to the project
Thanks!
Hey @LucaGobbo Thanks for the great PR! Next time it's best to open an issue so we can discuss before implementation, let me think about this some more, I wouldn't want tens of flags to configure every tiny aspect, but this seems mostly reasonable
Codecov Report
Merging #46 (90487fb) into main (6ad1d4f) will increase coverage by
0.01%. The diff coverage is100.00%.
@@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 97.33% 97.35% +0.01%
==========================================
Files 21 21
Lines 1578 1586 +8
==========================================
+ Hits 1536 1544 +8
Misses 42 42
| Impacted Files | Coverage Δ | |
|---|---|---|
| Sources/PrismCore/Models/Configuration.swift | 100.00% <100.00%> (ø) |
|
| Sources/PrismCore/Prism.swift | 86.90% <100.00%> (+0.07%) |
:arrow_up: |
| Tests/ConfigurationSpec.swift | 100.00% <100.00%> (ø) |
|
| Tests/TemplateParserSpec.swift | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 6ad1d4f...90487fb. Read the comment docs.
So sorry for taking so long to review this! @LucaGobbo Given a rebase and fixing up the CI, I think we can merge this.
Would you mind renaming it to just ignored_styleguides without the specificity of ID?
I'm just wondering if we should encapsulate it differently in the configuration, but we can possibly do that later on if the need arises.
Thank you!