GeoSot

Results 84 comments of GeoSot

Dropdown, by [default ](https://getbootstrap.com/docs/5.2/components/dropdowns/), supports two elements (menu, toggle), inside a wrapper. So I suppose this can be solved using a wrapper (div) around each dropdown. However, it seems was...

Nice job @pierresouchay . I 've done some testing it and seems it brings another 'feature', enabling use ids starting with number. Please add some tests to support your MR...

You can try `npm run js-debug` and `npm run js-lint` before pushing, too 😉

You probably need to add a test on `index.spec.js` => `getSelector` and to handle the same thing in the `getElement` function (plus proper test) 😃

Discussing this with @XhmikosR , there are about 7 usages of `querySelector` inside the code base. Indeed, your proposal is valid, but it doesn't cover all possibilities. ![image](https://user-images.githubusercontent.com/22406063/147088730-bd224324-2eba-43e4-ba31-64ae22ae70e5.png) I can...

Personally, I am ok with this check ` (selector && selector.startsWith('#') && window.CSS && window.CSS.escape)` @XhmikosR , please tell us you opinion. shall we go with the MVP or not?

I 'll approve it as it solves the 3 issues, keeping in mind that it is not an end up solution (the other 7 occurrences have to be changed in...

Hello, we had discussed a bit. I can recall that the main thoughts were that : * we have multiple places we are using the `querySelector` (so would be inconsistent...

>btw probably worth saying: it might look like i just come in here to point out what's wrong... but this is already a great way forward! if we can tweak...

thank you @patrickhlauke :) I was aware of duplicated feedback elements, but I wasn't sure how to solve it. Although, I think I have found a valid solution. > lastly,...