Geert-Johan Riemer

Results 151 comments of Geert-Johan Riemer

Hmm... But then the Handler would look like the one @inconshreveable proposed? ``` go type BulkHandler interface { Handler Flush() error } ``` And what about MultiHandler or FailoverHandler? Can...

In this case the `*Record` still contains a field `Flush bool`? Or has that idea been dropped?

I don't think all buffering Handlers should work with a WriteFlusher, Flush doesn't always apply to a stream of bytes. WriteFlusher won't work for the LogglyHandler. So this only solves...

It's been a while, sorry for not responding.. Busy times.. I still see some problems with `Flush bool`. One is that because the Record is passed by pointer in the...

1. Good point. How do you propose we vendor it? 2. I think it could, but do you really want that? Eventually there might be a lot of external logging...

Any update on this? Would like to get it merged :)

1. See below. 2. I agree, I think it's cleaner to gather logging hooks to external systems in a subdirectory so it's not polluting the project root. 3. Still think...

Great! I'll update this PR with the loggly http API asap, probably this evening (CET).

Some delay: I want to know if the log level (debug, info, crit) should be in a specific format so it is recognized by loggly. Because `segmentio/go-loggy` uses a different...

Nevermind, it looks like levels are not defined by loggly.