Philip Howard

Results 958 comments of Philip Howard

Oh wait hold up, I have totally flubbed the repackaging and it wont work!

It should be working now. Basically the installation *when it works properly* is entirely self contained within the `~/.virtualenvs/pimoroni` virtual environment. This is just a folder that, by means of...

There should not be any need to roll it back. Just running the latest installer should, in theory, give you an environment with the library installed and ready to go....

To preserve 12-key-rollover Keybow's `set_modifier` uses a bitmask set of modifier keys that's limited to 8, with the modifier keys indexed into it like so: ``` keybow.LEFT_CTRL = 0 keybow.LEFT_SHIFT...

Sorry for the radio silence- this looks interesting, thank you! I don't know when we'll get around to reviewing & merging, but we're starting to build a bit more process...

Near as I can tell, there's nothing wrong with what you're attempting and a cursory check over the code doesn't yield any obvious problems. I'll try and run a debug...

Ooof, lack of documentation hurts here- it should be: ``` keybow.load_pattern("patterns/rainbow") ``` The `png` part is, for better or worse, added automatically. A quick local test shows this is at...

Clearly we need some comprehensive documentation on this functionality- `keybow.auto_lights(false)` completely disables the image-based animation sequencing and light patterns in favour of setting individual LEDs manually.

Absolutely- all the C source is here to browse: https://github.com/pimoroni/keybow-firmware/tree/master/keybow Here's what `keybow.load_pattern` boils down to: https://github.com/pimoroni/keybow-firmware/blob/7f359e567860eff871da96bbbad98a3eaac0377c/keybow/lua-config.c#L358-L374 Which, in turn, calls `read_png_file` in C: https://github.com/pimoroni/keybow-firmware/blob/fd7b19a8818c11fd300d37ba20e83db542aac2ec/keybow/lights.c#L19-L84 And `keybow.auto_lights`: https://github.com/pimoroni/keybow-firmware/blob/7f359e567860eff871da96bbbad98a3eaac0377c/keybow/lua-config.c#L301-L307

I can't remember the exact motivation behind this eldritch horror, but I don't believe I use `device.register.set_field()` anywhere in any library based on i2c-device. Presumably I wanted `device.some_settings_register.set_field(1)` to work,...