gnome-shell-extension-gsconnect icon indicating copy to clipboard operation
gnome-shell-extension-gsconnect copied to clipboard

WIP: GNOME 43

Open fabianhjr opened this issue 3 years ago • 4 comments

This sort of works

closes #1428

fabianhjr avatar Aug 25 '22 03:08 fabianhjr

Added a link to the issue, just so it shows up there if someone wants to help out :)

andyholmes avatar Aug 29 '22 16:08 andyholmes

Just an FYI, I'm a bit stump on how to upgrade so anyone else that wants to propose/try another solution feel free to go ahead.

fabianhjr avatar Aug 30 '22 01:08 fabianhjr

How about something like this?

// Since GNOME 43: aggregateMenu -> quickSettings
if (Main.panel.statusArea.quickSettings)
    const AggregateMenu = Main.panel.statusArea.quickSettings;
else
    const AggregateMenu = Main.panel.statusArea.aggregateMenu;

jbicha avatar Sep 01 '22 19:09 jbicha

For anyone looking to contribute to this PR, note that you will probably want to do more that just swap aggregateMenu with quickSettings, since this is a new API.

We have a short tutorial on how to use this API on gjs.guide with examples. It may not end up being exactly compatible with GSConnect's eccentric GMenu implementation though.

andyholmes avatar Sep 02 '22 17:09 andyholmes

I don't think quality of my code is good enough for a PR so I'm not creating one. Here's my commit if you want to use it while official support comes: https://github.com/MacTavishAO/gnome-shell-extension-gsconnect/commit/5b381ff80fc9929ad551ddbbc0581462cb4393ca

MacTavishAO avatar Sep 30 '22 18:09 MacTavishAO

Way better than what little I have been able to do. Can't currently work on this further.

fabianhjr avatar Sep 30 '22 18:09 fabianhjr

@MacTavishAO Apparently your code quality is good enough according to @fabianhjr. Please create a new PR.

yochananmarqos avatar Sep 30 '22 22:09 yochananmarqos

@MacTavishAO Apparently your code quality is good enough according to @fabianhjr. Please create a new PR.

I'm reworking on it. I will in couple of hours.

MacTavishAO avatar Oct 01 '22 16:10 MacTavishAO

Great!

daniellandau avatar Oct 01 '22 16:10 daniellandau

PR is up. #1475

MacTavishAO avatar Oct 01 '22 19:10 MacTavishAO