ThirtyInch

ThirtyInch copied to clipboard

It'd be cool if BottomSheetDialogFragment is supported out of the box.

Looking forward for the next release 👍

All you have to do is add this and you have turned your standard DialogFragment into a BottomSheetDialogFragment 😄

@iffa well that's genius, I really didn't give it a thought lol. Thanks

@passsy I guess this could be closed, however it might be good to include this workaround some where.

We will not provide a TiBottomSheetDialogFragment because it would require a new dependency. But I'll leave it open because we could support composition instead of inheritance in the future without using CompositeAndroid.

ActivityLifecycleCallbacks & FragmentLifecycleCallbacks 🚀

@passsy make sense, but the workaround solution posted here is actually pretty easy to implement and one could use it without writing plenty of code, I guess it would be cool if its documented somewhere for others to notice because now bottomSheets are the new Dialogs .