sway

sway copied to clipboard

• Renamed visit_expr() to expr_leaf_spans() in sfv2 #2509

• Used while let in place of for in peekable() iterations in sfv2 #2496

@Tusharkshahi thanks for the contribution! There are a few things failing in CI, I'll go ahead and convert this PR to a draft for now and when you're ready for review just re-open it as ready (:

It looks like CI is failing in three places:

1. the format check, which can be fixed by running cargo fmt in your code.
2. clippy, which I'm actually not sure why is failing on this branch. Your changes appear to be unrelated. I'll look into that.
3. the correctness checks for the formatter. Some of the changes in this PR are altering the functionality of the formatter and causing it to behave differently. You can run these tests locally by running cargo test in the formatter v2 directory and debug accordingly 😄 hint: cloning an iterator allows you to consume the clone without progressing the original iterator that was cloned.

As #2518 merged, unrelated clippy failure in CI should be resolved. I merged master here to resolve that here

@Tusharkshahi let us know if there's anything we can help with!

@Tusharkshahi I'm going to close this PR as it's gathering dust, however if you'd like to rebase and take on the suggestions above feel free to re-open!