fuel-core icon indicating copy to clipboard operation
fuel-core copied to clipboard

Published 20 hours ago • verified publisher icon FuelLabs

Review Imports

Open ControlCplusControlV opened this issue 3 years ago • 6 comments

Review Imports, several places where nested imports are needed. Also make sure all importing is done through fuel_core_interfaces rather than directly

ControlCplusControlV avatar Aug 05 '22 17:08 ControlCplusControlV

Is this issue still open? I'd like to give it a try.

ch1n3du avatar Aug 16 '22 09:08 ch1n3du

Yes, go for it!

ControlCplusControlV avatar Aug 16 '22 13:08 ControlCplusControlV

What style do you prefer

One:

Screenshot from 2022-08-19 10-20-40

Two:

Screenshot from 2022-08-19 10-20-30

ch1n3du avatar Aug 19 '22 09:08 ch1n3du

Currently I'm using the first style but the second seems a bit more readable

ch1n3du avatar Aug 19 '22 09:08 ch1n3du

I think rustfmt would only allow the first option 🤔

Voxelot avatar Aug 19 '22 12:08 Voxelot

Made a pr I had some issues I wasn't able to solve.

ch1n3du avatar Aug 19 '22 20:08 ch1n3du

closing as our new nightly rustfmt config resolves this issue

Voxelot avatar Sep 14 '22 19:09 Voxelot