BlazorWebFormsComponents icon indicating copy to clipboard operation
BlazorWebFormsComponents copied to clipboard

Attribute Value Conflicts

Open csharpfritz opened this issue 5 years ago • 4 comments

from @grleachman in #21

Attribute Value Conflicts

Adding RepeatDirection has caused a conflict with GridLines

There's now an ugly problem where the static enums require the markup to be messy:

Gridlines="Enums.GridLines.Horizontal" RepeatDirection="Enums.RepeatDirection.Horizontal"

This is going to be painful for migration.

csharpfritz avatar Feb 12 '20 15:02 csharpfritz

I think the better way to fix this is not using Enums namespace? I can file an issue regarding namespace change suggestion that may make the migration so simple

hishamco avatar Feb 22 '20 21:02 hishamco

Is there a reason to declare enum as abstract class?

hishamco avatar Feb 23 '20 21:02 hishamco

There are other features we need to these enums and by taking this approach we get pattern matching to check if the enum is selected

Jeff

On Feb 23, 2020, at 16:07, Hisham Bin Ateya [email protected] wrote:

 Is there a reason to declare enum as abstract class?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

csharpfritz avatar Feb 23 '20 22:02 csharpfritz

Is this working fine?

Gridlines="GridLines.Horizontal"
RepeatDirection="RepeatDirection.Horizontal"

hishamco avatar Feb 26 '20 10:02 hishamco