BlazorWebFormsComponents icon indicating copy to clipboard operation
BlazorWebFormsComponents copied to clipboard

AdRotator DataBinding features

Open csharpfritz opened this issue 5 years ago • 8 comments

AdRotator needs to support the DataBinding features like:

  • [ ] DataSource
  • [ ] DataMember
  • [ ] DataBinding Events
  • [x] AlternateTextField
  • [x] ImageUrlField
  • [x] NavigateUrlField
  • [x] OnAdCreated

csharpfritz avatar Aug 23 '20 15:08 csharpfritz

I can work on this one ...

hishamco avatar Aug 23 '20 17:08 hishamco

You got it @hishamco !

csharpfritz avatar Aug 23 '20 18:08 csharpfritz

@csharpfritz is there ability to edit your first thread so I can check the one that have been done while I'm working on

hishamco avatar Aug 23 '20 19:08 hishamco

I finished from the last 4 features, I will create another PR for DataBinding later on ...

hishamco avatar Aug 24 '20 00:08 hishamco

Just thinking about DataSource I think we should do similar to what we did when we bound DataTable to GridView. Regarding DataMember I don't think I used in the past so your thought @csharpfritz?

hishamco avatar Aug 24 '20 00:08 hishamco

@csharpfritz I start work to make AdRotator a DataBoundCompoment but the issue is both DataSource and DataMember are associate with DataSource controls in ASP.NET, so mark them as Obsolete may a better choice unless we need to bind it with DataTable but this need some efforts to map table columns to AdRotator properties

Your thoughts?

hishamco avatar Aug 30 '20 16:08 hishamco

DataSourceID is used with DataSource controls in ASP.NET. DataSource and DataMember work with code-behind and DataBinding. Let's NOT mark those as Obsolete.

Agreed about rolling the same databinding interactions just completed for GridView to the other data bound controls

csharpfritz avatar Aug 30 '20 16:08 csharpfritz

DataSourceID is used with DataSource controls in ASP.NET.

Oops, just forgot that one ;)

Agreed about rolling the same databinding interactions just completed for GridView to the other data bound controls

Sounds good, but the issue here is based on the convention to map the AdRotator properties

hishamco avatar Aug 30 '20 17:08 hishamco