FreeTAKHub-Installation icon indicating copy to clipboard operation
FreeTAKHub-Installation copied to clipboard

Update configuration files upon installation with Explicit IP Address

Open phreed opened this issue 1 year ago • 2 comments

Identify and correct all places where the FTS IP addres, as provided by the --ip-addr argument, needs to be set.

  • [ ] The IP address for node-red configuration are being left in their default values.
  • [ ] When users are added, their certificates are incorrectly generated with the DHCP assigned LAN address.

What other configuration files are not properly configured?

phreed avatar Mar 27 '24 16:03 phreed

Regarding the issue with ip-addr on the certificates.

"When I add users, it looks like their Certs are being generated with the current DHCP assigned LAN IP address instead of the custom IP address that I fed into the ZTI installer." -- Slevin

@ghosty says: https://github.com/FreeTAKTeam/FreeTakServer/blob/master/FreeTAKServer/core/util/certificate_generation.py is responsible for basically all cert gen.

In it I see two functions:

  • generate_auto_certs https://github.com/FreeTAKTeam/FreeTakServer/blob/fff91b109f54630753f7e410e71c36afec0825de/FreeTAKServer/core/util/certificate_generation.py#L509
  • copy_server_certs https://github.com/FreeTAKTeam/FreeTakServer/blob/fff91b109f54630753f7e410e71c36afec0825de/FreeTAKServer/core/util/certificate_generation.py#L489

These are used by:

  • https://github.com/FreeTAKTeam/FreeTakServer/blob/fff91b109f54630753f7e410e71c36afec0825de/FreeTAKServer/services/rest_api_service/blueprints/user_management_blueprint.py#L60
  • https://github.com/FreeTAKTeam/FreeTakServer/blob/fff91b109f54630753f7e410e71c36afec0825de/FreeTAKServer/services/rest_api_service/rest_api_service_main.py#L409
  • https://github.com/FreeTAKTeam/FreeTakServer/blob/fff91b109f54630753f7e410e71c36afec0825de/FreeTAKServer/core/services/RestAPI.py#L474

Which all seem to use server_address=config.UserConnectionIP which comes from https://github.com/FreeTAKTeam/FreeTakServer/blob/fff91b109f54630753f7e410e71c36afec0825de/FreeTAKServer/core/services/RestAPI.py#L1465 MainConfig.py

phreed avatar Mar 29 '24 18:03 phreed

Correct

brothercorvo avatar Mar 29 '24 18:03 brothercorvo